fixed whitespace and line length for improved PEP8 conformance#6
Open
FND wants to merge 1 commit intocomcast-jonm:masterfrom
Open
fixed whitespace and line length for improved PEP8 conformance#6FND wants to merge 1 commit intocomcast-jonm:masterfrom
FND wants to merge 1 commit intocomcast-jonm:masterfrom
Conversation
|
I'm generally in favor of nit-picky fixes by citizens. :) I don't have time to review in depth right now but will try to get around to it soon. Thanks for contributing! |
Author
|
Excellent, thanks! FWIW, I wanted to restructure the script a bit, but that proved tricky in the absence of tests (whether automated or manual) - any chance you could open-source the server component you used during your presentation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in an effort to be a good (if nit-picky) citizen
note that I did not alter the inline return statements because that seemed like potentially an intentional decision